Skip to content

ads-client: Use AdsClientUrl consistently #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bendk wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

ads-client: Use AdsClientUrl consistently #7420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions components/ads-client/src/ffi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ use crate::mars::ad_response::{
};
use crate::mars::Environment;
use crate::mars::ReportReason;
use crate::AdsClientUrl;
use crate::MozAdsClient;
use parking_lot::Mutex;
use std::collections::HashMap;
use url::Url;

pub use error::{AdsClientApiResult, MozAdsClientApiError};
pub use telemetry::MozAdsTelemetry;
Expand Down Expand Up @@ -93,9 +93,9 @@ pub struct MozAdsPlacementRequestWithCount {

#[derive(Debug, PartialEq, uniffi::Record)]
pub struct MozAdsCallbacks {
pub click: Url,
pub impression: Url,
pub report: Option<Url>,
pub click: AdsClientUrl,
pub impression: AdsClientUrl,
pub report: Option<AdsClientUrl>,
}

#[derive(uniffi::Object)]
Expand Down
Loading