remove WNP dead code#17260
Open
wen-2018 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Firefox “What’s New” v146 donation experience (template, styling, localization, and routing) from Bedrock, cleaning up WNP 146 donate-related dead code.
Changes:
- Removes the
firefox_whatsnew_146_donatestatic bundle and deletes its SCSS source. - Removes the
whatsnew-donateFluent resource and Pontoon configuration entry. - Removes the dedicated
whatsnew-fx146-donate.htmltemplate and the corresponding selection logic inWhatsnewView.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| media/static-bundles.json | Drops the firefox_whatsnew_146_donate bundle entry so it’s no longer built/served. |
| media/css/firefox/whatsnew/whatsnew-146-donate.scss | Removes now-unused styling for the v146 donate variant. |
| l10n/en/firefox/whatsnew/whatsnew-donate.ftl | Removes the now-unused Fluent strings for the v146 donate variant. |
| l10n/configs/pontoon.toml | Removes Pontoon path configuration for the deleted whatsnew-donate.ftl resource. |
| bedrock/firefox/views.py | Removes v146 donate template mapping and routing/selection logic. |
| bedrock/firefox/templates/firefox/whatsnew/whatsnew-fx146-donate.html | Deletes the v146 donate variant template. |
Contributor
|
Nice work going beyond my original note. I'd only flagged the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
This PR removes WNP 146 donate related dead code.
Significant changes and points to review
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-1380
#17241 (comment)
Testing