Bug 2034845 - Fix broken Access Connector on policy modification#809
Open
jporter-dev wants to merge 4 commits intomozilla:enterprise-mainfrom
Conversation
jporter-dev
added
bug
jporter-dev
force-pushed
the
enterprise-bug2034845-access-connector-live-policy-modification
branch
4 times, most recently
from
94a8a20 to
47d71ac
Compare
…ive inclusion.match_patterns pref changes
…s for host and port updates
jporter-dev
force-pushed
the
enterprise-bug2034845-access-connector-live-policy-modification
branch
from
47d71ac to
8436997
Compare
…rt become invalid and terminate VPN connection
Contributor
|
@jporter-dev Now that we have #825 there is no reason not to rebase and add proper testing to ensure this does not regress |
lissyx
reviewed
May 5, 2026
| ); | ||
|
|
||
| this.#handleListChanged = () => this.init(); | ||
| this.#handleListChanged = async () => { |
Contributor
There was a problem hiding this comment.
Do we really need the async ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that occurs when the
AccessConnectorpolicy is modified in-place (not added/removed). This results in a broken access connector due to the#inclusionListnot being updated whenMatchPatternschanges, and the connection not being re-initialized with the new server when the serverlist changes (host/port in policy)Bugzilla: Bug-2034845
IPProtectionServerlist.sys.mjs: fixPrefServerListpref observer registration (was referencing instance instead of class), skip in maybeFetchList() when pref value is unchangedIPPChannelFilter.sys.mjs: register/unregister pref observer to refresh#inclusionSetwhen changedIPPProxyManager.sys.mjs: addreconnectmethod for reconnecting to the recommended server from the updated listIPPAutoStart.sys.mjs: add logic to#handleListChangedto reconnect on live changesDependencies / Related Issues
Testing
Steps to verify changes:
MatchPatternsExpected result:
AccessConnector shows active/inactive properly when modifying policy