Conversation
moibra05
requested review from
freshstrangemusic,
jaredlockhart,
mikewilli,
relud and
yashikakhurana
as code owners
Contributor
Author
|
moibra05
force-pushed
the
14830
branch
2 times, most recently
from
59316cc to
7eaa79e
Compare
Contributor
Author
|
mikewilli
requested changes
Mar 9, 2026
Contributor
mikewilli
left a comment
mikewilli
left a comment
There was a problem hiding this comment.
Looking great, just have a few more UI requests and a few other small suggestions.
experimenter/experimenter/nimbus_ui/templates/common/branch_card.html
Outdated
Show resolved
Hide resolved
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-inner.html
Outdated
Show resolved
Hide resolved
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-inner.html
Outdated
Show resolved
Hide resolved
experimenter/experimenter/nimbus_ui/templates/common/branch_card.html
Outdated
Show resolved
Hide resolved
mikewilli
reviewed
Mar 9, 2026
experimenter/experimenter/nimbus_ui/templates/common/branch_card.html
Outdated
Show resolved
Hide resolved
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-inner.html
Outdated
Show resolved
Hide resolved
experimenter/experimenter/nimbus_ui/templates/common/branch_card.html
Outdated
Show resolved
Hide resolved
mikewilli
approved these changes
Mar 18, 2026
Contributor
mikewilli
left a comment
mikewilli
left a comment
There was a problem hiding this comment.
LGTM and excited to have this on the Results page! Thanks! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #14830