fix(nimbus): skip cloning screenshots with no associated image file#14912
Merged
jaredlockhart merged 1 commit intomainfrom Mar 16, 2026
Merged
fix(nimbus): skip cloning screenshots with no associated image file#14912jaredlockhart merged 1 commit intomainfrom
jaredlockhart merged 1 commit intomainfrom
Conversation
Because * Cloning an experiment with a branch screenshot whose image file is missing from storage raises ValueError, crashing the clone operation * This was reported via Sentry (EXPERIMENTER-PROD-197) This commit * Adds a guard in NimbusBranchScreenshot.clone() to return None when the image field has no file associated * Adds a test that reproduces the ValueError from the Sentry report Fixes #14911 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaredlockhart
requested review from
freshstrangemusic,
mikewilli,
relud and
yashikakhurana
as code owners
relud
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
missing from storage raises
ValueError: The 'image' attribute has no file associated with it., crashing the clone operationThis commit
NimbusBranchScreenshot.clone()to returnNonewhenthe image field has no file associated, skipping the broken screenshot
ValueErrorfrom the Sentry reportFixes #14911