Skip to content

fix(storybook): fix broken PageSecondaryEmailAdd and PageChangePassword stories#20425

Merged
vpomerleau merged 1 commit intomainfrom
fix-broken-settings-stories
Apr 21, 2026
Merged

fix(storybook): fix broken PageSecondaryEmailAdd and PageChangePassword stories#20425
vpomerleau merged 1 commit intomainfrom
fix-broken-settings-stories

Conversation

@vpomerleau
Copy link
Copy Markdown
Contributor

Because

  • PageSecondaryEmailAdd and PageChangePassword stories were not loading because of a missing AppContext Provider

This pull request

  • Adds the missing provider

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@vpomerleau vpomerleau requested a review from a team as a code owner April 21, 2026 22:24
Copilot AI review requested due to automatic review settings April 21, 2026 22:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two broken Storybook stories in fxa-settings by ensuring pages that rely on AppContext hooks are rendered with an AppContext.Provider.

Changes:

  • Add AppContext.Provider around PageSecondaryEmailAdd story rendering.
  • Add AppContext.Provider around PageChangePassword story rendering (using mockAppContext()).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/fxa-settings/src/components/Settings/PageSecondaryEmailAdd/index.stories.tsx Wraps the story in AppContext.Provider using mockAppContext() so hooks like useAccount() don’t throw.
packages/fxa-settings/src/components/Settings/PageChangePassword/index.stories.tsx Wraps the story in AppContext.Provider using mockAppContext() so hooks like useAccount() don’t throw.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vpomerleau vpomerleau merged commit 474a645 into main Apr 21, 2026
25 checks passed
@vpomerleau vpomerleau deleted the fix-broken-settings-stories branch April 21, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants