Skip to content

wip feat(passkey): Add glean metrics for passkey registration and management#20426

Draft
vpomerleau wants to merge 1 commit intomainfrom
FXA-13418
Draft

wip feat(passkey): Add glean metrics for passkey registration and management#20426
vpomerleau wants to merge 1 commit intomainfrom
FXA-13418

Conversation

@vpomerleau
Copy link
Copy Markdown
Contributor

DRAFT Needs to be rebased once the passkey management ui wiring is merged

Because

  • We need interaction data to understand passkey adoption and failure modes

This pull request

  • Defines 8 new account_pref.passkey_* events in fxa-ui-metrics.yaml
  • Regenerates accountPref.ts via glean_parser
  • Adds eventsMap entries and recordEventMetric switch cases
  • Instruments UnitRowPasskey (create submit), PagePasskeyAdd (view/success/error/cancel), and PasskeySubRow (delete submit/confirm/success)
  • passkey_add_error includes reason extra key (webauthn/server/mfa_expired)
  • Adds Glean mock and assertions to component test files
  • Adds ping submission tests for all 8 events in lib/glean/index.test.ts

Issue that this pull request solves

Closes: FXA-13418

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

* We need interaction data to understand passkey adoption and failure modes

This commit:

* Defines 8 new account_pref.passkey_* events in fxa-ui-metrics.yaml
* Regenerates accountPref.ts via glean_parser
* Adds eventsMap entries and recordEventMetric switch cases
* Instruments UnitRowPasskey (create submit), PagePasskeyAdd (view/success/error/cancel), and PasskeySubRow (delete submit/confirm/success)
* passkey_add_error includes reason extra key (webauthn/server/mfa_expired)
* Adds Glean mock and assertions to component test files
* Adds ping submission tests for all 8 events in lib/glean/index.test.ts

Closes #FXA-13418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant