wip feat(passkey): Add glean metrics for passkey registration and management#20426
Draft
vpomerleau wants to merge 1 commit intomainfrom
Draft
wip feat(passkey): Add glean metrics for passkey registration and management#20426vpomerleau wants to merge 1 commit intomainfrom
vpomerleau wants to merge 1 commit intomainfrom
Conversation
Because: * We need interaction data to understand passkey adoption and failure modes This commit: * Defines 8 new account_pref.passkey_* events in fxa-ui-metrics.yaml * Regenerates accountPref.ts via glean_parser * Adds eventsMap entries and recordEventMetric switch cases * Instruments UnitRowPasskey (create submit), PagePasskeyAdd (view/success/error/cancel), and PasskeySubRow (delete submit/confirm/success) * passkey_add_error includes reason extra key (webauthn/server/mfa_expired) * Adds Glean mock and assertions to component test files * Adds ping submission tests for all 8 events in lib/glean/index.test.ts Closes #FXA-13418
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT Needs to be rebased once the passkey management ui wiring is merged
Because
This pull request
Issue that this pull request solves
Closes: FXA-13418
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.