Bug 1907892 Expose MemoryDistribution's accumulate samples#3418
Open
Jtech3029 wants to merge 2 commits intomozilla:mainfrom
Open
Bug 1907892 Expose MemoryDistribution's accumulate samples#3418Jtech3029 wants to merge 2 commits intomozilla:mainfrom
Jtech3029 wants to merge 2 commits intomozilla:mainfrom
Conversation
Copied the function signature and comment from /metrics implementation and exposed on MemoryDistribution's trait
badboy
requested changes
Mar 13, 2026
| /// | ||
| /// Please note that this assumes that the provided samples are already in | ||
| /// the "unit" declared by the instance of the metric type (e.g. if the the | ||
| /// instance this method was called on is using [`MemoryUnit::Kilobyte`], then |
Member
There was a problem hiding this comment.
Suggested change
| /// instance this method was called on is using [`MemoryUnit::Kilobyte`], then | |
| /// instance this method was called on is using [`crate::MemoryUnit::Kilobyte`], then |
This should fix the CI test failure (which complained about not finding the MemoryUnit type)
Copied the function signature and comment from /metrics implementation and exposed on MemoryDistribution's trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied the function signature and comment from /metrics implementation and exposed on MemoryDistribution's trait