Skip to content

Fix search option label names to match settings and search UI#4031

Open
huseynovvusal wants to merge 1 commit intomozilla:mainfrom
huseynovvusal:fix/search-option-labels
Open

Fix search option label names to match settings and search UI#4031
huseynovvusal wants to merge 1 commit intomozilla:mainfrom
huseynovvusal:fix/search-option-labels

Conversation

@huseynovvusal
Copy link
Copy Markdown

@huseynovvusal huseynovvusal commented Mar 20, 2026

Summary

This PR fixes a UI inconsistency between:

  • /settings/ (Default search options in contributor settings)
  • /search/ (Search page checkbox filters)

Before:

  • settings: Match case, Match whole word, Search in string identifiers
  • search: Case sensitive, Entire words, Search in string identifiers (mixed naming)

After:

  • both sides now use the same labels:
    • Match case
    • Match whole word
    • Search in string identifiers
    • Include rejected translations
    • Exclude source strings

Files changed

  • constants.ts
  • search.html

Why

  • Prevents UX confusion when users switch between settings and search controls
  • Improves internationalization / localization key consistency
  • Avoids subtle test breakage from label mismatch

Testing

  1. docker compose up -d --build
  2. cd translate && npm run start
  3. Open:
    • http://localhost:8000/settings/
    • http://localhost:8000/search/
  4. Verify labels are consistent.
  5. Run tests:
    • npm run test --workspace=translate -- --run src/modules/search/components/SearchPanel.test.jsx

Closes #4029

@mathjazz
Copy link
Copy Markdown
Collaborator

Thanks for the patch!

Sadly the layout breaks into two lines:
Screenshot 2026-03-23 at 08 33 22

Please adjust it accordingly. Somethink like this would work:

/* search.css | http://localhost:8000/static/css/search.css */

& .check-box {
  & .check-box-wrapper {
    /* margin-left: 20px; */
    margin-left: 15px;
  }
}

#main {
  & .container {
    & menu {
      & .search-options {
        & .check-list {
          width: 490px;
          text-align: right;
        }
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use consistent names for search option checkbox labels in Search and Settings pages

2 participants