Modify django-allauth to not use SocialApp#4046
Open
functionzz wants to merge 1 commit intomozilla:mainfrom
Open
Modify django-allauth to not use SocialApp#4046functionzz wants to merge 1 commit intomozilla:mainfrom
functionzz wants to merge 1 commit intomozilla:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the most recent bump for django-allauth #3867, we realized that we disregarded the
python manage.py ./update_auth_providerscommand, of which when run now, causes issues as Keycloak as a seperate provider no longer exists.Recently, a new revelation has emerged: in the new django-allauth, we don't need to use the
SocialAppmodel to keep track of Social account providers any longer. Within the documentation, it is clear that when picking either theSOCIALACCOUNT_PROVIDERsettings method orSocialAppmodel method, we should pick one, lest there be aMultipleObjectsReturnedexception for duplicate providers.I selected the
SOCIALACCOUNT_PROVIDERsettings method because it is recommended, does not require the database at all, is better documented and eliminates the need forupdate_auth_providers.Fixes #4013.
Additional Information
Upon this PR being cleared and merged into main, please make sure to delete the
Social applications&Social application tokensdb table, as they are no longer necessary.