Bump opendal to 0.56.0 and fix fallout (fixes local GCS cache usage)#2715
Bump opendal to 0.56.0 and fix fallout (fixes local GCS cache usage)#2715flip1995 wants to merge 4 commits into
Conversation
- Required bump of reqwest to 0.13.0
- Rename and remove features deprecated in that release
- Update `Cargo.lock` file
- Remove direct `reqsign` dependency that was not used in the code
- Add new opendal-layer-logging dependency that was split out of opendal
- Fix fallout in code from `LoggingLayer` split in opendal
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
==========================================
- Coverage 74.41% 73.57% -0.84%
==========================================
Files 70 70
Lines 39211 39559 +348
==========================================
- Hits 29177 29104 -73
- Misses 10034 10455 +421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure why CI is failing. I'd appreciate any pointers how I can try to reproduce those locally and debug. EDIT: Managed to reproduce the dist tests locally. |
|
Hm, the dist tests are running into this issue: seanmonstar/reqwest#2988 |
|
@sylvestre could you approve the CI run please. I think my latest commit has fixed the |
|
Blocked by apache/opendal#7701 and the following opendal release. |
|
@sylvestre With de7fa43 I'm patching the opendal dependency to my branch of apache/opendal#7701. This should make the CI of this PR pass. But to merge this PR, we'll have to wait until my opendal fix is released. This commit is just for me to check if there's anything else I need to fix after this. Could you approve the CI run one more time, please? Totally understandable if you don't want to approve this with such external changes included in the PR. Happy to wait until the opendal fix is through in that case. |
reqsigndependency that was not used in the codeCargo.lockfileLoggingLayersplit in opendalMotivation:
authorized_usercredential apache/opendal#6287The gcs cache can currently not be used with
authorized_userapplication-default credentials, as this was not supported inreqsignversion 0.16.5, whichopendalversion0.55.0depended on. This was fixed in a later version of reqsign and since has been updated inopendalWith this, the gcs cache should Just Work ™️ after a
gcloud auth application-default login.