-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
WebGLRenderer: Apply premultiplied alpha in sRGB space #32470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
98b00c2 to
07c01a9
Compare
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
To me this seems like a good, well targeted change. The last thing I would suggest is not deleting the "premultiplied_alpha_fragment" shader chunk because it will be a breaking change for anyone using it. And not all shaders use the "opaque_fragment" chunk, as you'll see in the LDrawConditionalLineMaterial.js file. I often add it to the end of my shaders after setting the final gl_FragColor value in order to respect the premultiply alpha flag. |
a759fe0 to
9d64c2f
Compare
|
Reverted. But hmm... I'm unsure about this change. |
Related issue: #32449 (comment)
It sure looks like an improvement!