fix: Change 'yuv' from -full to -video range#4032
Open
mrousavy wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion with @wcandillon in #4022, I discovered that the de-facto default on iOS is actually
kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange, notkCVPixelFormatType_420YpCbCr8BiPlanarFullRange.So in this PR we change that - if you pass
'yuv'to yourFrameOutputit now represents video range, not full range 8-bit YUV 4:2:0 buffers.Technically a breaking change, although pretty much all libraries handle both full and video range. So I doubt anybody will notice anything.