Allow packing of arrays with {pack_str, from_list}#81
Open
cleverfox wants to merge 2 commits intomsgpack:masterfrom
Open
Allow packing of arrays with {pack_str, from_list}#81cleverfox wants to merge 2 commits intomsgpack:masterfrom
cleverfox wants to merge 2 commits intomsgpack:masterfrom
Conversation
Lists tagged with {array, List} will be forcely encoded as arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Today for I have a little patch for your review. In my project I use binaries and strings simultaneously and had no problems before today. Now I also needed to use arrays (with strings and binaries) and got few problems. I guess special tag for arrays will be useful in case if default behaviour should be strings and you need arrays very seldom.
Lists tagged with {array, List} will be forcely encoded as arrays.