admin: show the Microsoft button only when interactive login exists - #18
Merged
Conversation
Same /health-driven gating me.html already has — on token-only deployments the sign-in panel no longer renders a "Sign in with Microsoft" button that would 404 on /auth/login. Copy adjusted so the token paragraph reads standalone; UI guide screenshot and note updated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/adminsign-in panel rendered "Sign in with Microsoft" unconditionally — on token-only deployments clicking it hit a non-existent/auth/login. Now it uses the same/health-driven gatingme.htmlalready has: the button appears only whenlogin: true; a failed/healthprobe keeps it hidden and never blocks the token box. Copy tweaked ("Or paste…" → "Paste…") so the paragraph reads standalone, and the UI guide's screenshot + note updated to match.Test plan
npm test— 211 passed/adminshows only the token box; token sign-in works/me(/health.logincovered by oauth-flow tests)🤖 Generated with Claude Code