Open
Conversation
…ests should be passing, with some warnings. Will now begin cleaning code
mtalexan
reviewed
Dec 20, 2019
Owner
|
@ralittles What's the benefit of using pytest vs testtools? It doesn't integrate with the setup.py (or at least you didn't integrate it), and it only works for Python3. |
Owner
|
@ralittles I think if the project is going to drop support for python2 and switch over to python3 only, this could be accepted. However you would need to update the setuptools to use pytest instead of testtools for the test target, and drop the old testtools code. |
s31db
pushed a commit
to s31db/VersionOne.SDK.Python
that referenced
this pull request
Mar 3, 2024
Token authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported all of the unit tests written in testtools from the
tests/directory to now be based on the pytest package and live in thepytests/directory.Unfortunately Pytest compatiability is limited to Python 3. To run them, do:
From the regular root directory of the project.
You should see:
The original tests/ directory was left in for Python 2 compatbility and are still accessible and passing via the target in
setup.py.Here are the results: