Install shims via in-image install command - #35
Merged
Conversation
Replace the GitHub-hosted scripts/install.sh channel with an in-image `whygraph install` command. `docker run --rm ghcr.io/mtrdesign/whygraph install | sh` emits the whygraph / whygraph-mcp host shims. - Add cli/commands/install.py that renders the POSIX sh installer + shims - Bake WHYGRAPH_VERSION into the image so shims pin a concrete release - Add an image-only /usr/local/bin/install launcher (no ENTRYPOINT) - Deploy workflow passes WHYGRAPH_VERSION and pins CODEGRAPH_VERSION=1.4.1 - Delete scripts/install.sh; update README/docs/CLAUDE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the published Docker image the single install channel. Instead of
curling a GitHub-hostedscripts/install.sh, the host runsdocker run --rm ghcr.io/mtrdesign/whygraph install | sh, which emits thewhygraphandwhygraph-mcpshims from inside the image. This drops the dependency on a raw GitHub URL and lets an install pin to a concrete release even when pulled via:latest.Changes
cli/commands/install.py— thewhygraph installsubcommand renders a POSIXshinstaller (to stdout only) that writes both host shims ontoPATH.WHYGRAPH_VERSIONinto the image (DockerfileARG/ENV) so generated shims pin the release they were installed from; still overridable per-command viaWHYGRAPH_IMAGE./usr/local/bin/installlauncher sodocker run <image> installworks without anENTRYPOINT(keepscodegraph …andwhygraph-mcpinvocations resolving).WHYGRAPH_VERSIONand pinsCODEGRAPH_VERSION=1.4.1.scripts/install.sh; update README, docs (installation / docker / service), and CLAUDE.md to the new one-liner.test_install_cmd.py(clean stdout, version pinning, end-to-end shim rendering) and a smoke test asserting the command registers.