Skip to content

lobby: player labels paint over the panel and chat #346

Description

@aaylward

Found while reviewing #345, pre-existing and not caused by it.

.playerLabelsContainer sits at z-index: 100 and is not in the .hudRight demotion list in ThoughtsGame.module.css, so in the lobby, where the HUD is on the right, player labels draw over the lobby panel (z 20) and the room chat (z 40 to 50). Any avatar standing behind those surfaces puts its name on top of them.

#345 hit exactly this with its splat overlay and fixed it for .tapeWallContainer by adding it to that demotion list. The same one-line fix applies here, but it is a separate pre-existing bug and did not belong in that PR.

Worth checking whether anything else in the file has the same shape while fixing it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions