golf: crown winners from the winners list only

[aaylward]

Closes #231.

The blocker is gone: MoonBase games_hub/model/golf.smithy GameEnded has winners @required, and src/apps/golf/wire.ts already types it non-optional.

Most of the issue's checklist was absorbed by the hub rewrite — useGolfGame, golfNetworkPlugin, networkAdapter and their legacy-path tests no longer exist. The one remaining fallback was GolfTable.isWinner comparing player.id === ended.winner when winners was empty. Removed.

winner (display string) stays: the contract sends it, and it feeds the "X wins!" headline and the game-over notice. Deriving it from winners would be more code for no gain.

Tests

• New: only the winners list crowns; the display string does not — winner: 'alice', winners: [] crowns nobody and still shows "alice wins!". Watched it fail on the old code (rendered "You won!"), pass after.
• typecheck, lint, test:run (1249 passed), build — all clean.
• Review panel not run; one-function change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FMAEXAt4rbVe5dSsKvvws4

---

Generated by Claude Code

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	muchq	b66d0b8	Commit Preview URL Branch Preview URL	Sep 29 2026, 07:32 PM

[cursor]

Blocking

None. golf.smithy GameEnded.winners is @required, and GolfGameEnded.winners is already non-optional on the wire — the player.id === ended.winner fallback was the last legacy path. Crowning is membership in winners only; winner stays as the joined display line for the celebration title and the game-over notice. The new test pins that winner alone crowns nobody (watched fail → pass). Issue #231’s other cleanup targets (useGolfGame, golfNetworkPlugin, …) are already gone. CI green.

Nits

None.

Fine

Small, contract-aligned cleanup. Closes #231.

---

Review of #392