chess: a table on the lobby, first variant king and pawn against king - #394
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
muchq | d9e8352 | Commit Preview URL Branch Preview URL |
Sep 30 2026, 08:17 PM |
|
Blocking
Nits
Fine Wire matches MoonBase Review of #394 |
Contributor
Author
|
Addressed in d9e8352:
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a chess table to the games lobby, on the backend's new
chessenvelope (muchq/MoonBase#1620).ChessTable: the board is drawn from the FEN with the viewer's side at the bottom, with file and rank labels.legalMoves; the client holds no rules.useChessTableholds the table's state and sends its moves. It is wired intouseLobby,hubStream, the lobby panel, the command menu, the table overlay, and the stats page's variant labels.seatsOf), since chess seats 2.Checks:
Review panel: four read-only agents covering React correctness, UX/a11y, wire and tests, and altitude. Their fixes are in 3d9ad00. The per-game registry is a follow-up, muchq/MoonBase#1621.
This needs muchq/MoonBase#1620 deployed first. Until then the hub rejects the
chessenvelope, and nothing else changes.