Repository navigation
fix(ui): stabilize backend lifecycle tests - #12828
Merged
Merged
Conversation
Wait for the node-specific reinstall control after URL navigation. The generic control shares its name and can retain the previous handler. Seed installed inventory before checking legacy backend navigation. Assert rendered selection and cover missing-selection cleanup separately. Keep deletion conflicts and final-node cleanup assertions intact. Assisted-by: nib:gpt-6.1-sol Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilize two backend UI tests without changing production behavior:
These address intermittent assertions in tests introduced by #12785 and #12526. No production code, configuration, timeouts, retries, or coverage gates change.
Notes for Reviewers
Verification uses Chromium, one worker, and retries disabled:
Before the final exact-request assertion, both complete specs passed (41 tests), and five affected cases passed ten repetitions (50 tests). Independent verification also passed both complete specs. After that assertion, both concurrency variants passed ten local repetitions and six independent repetitions. Targeted lint and diff checks pass.
The original signatures reproduced with retries off. Negative controls confirm that settled navigation rejects absent inventory and cleanup distinguishes present from missing selections. No full-suite or coverage-gate result is claimed.
Signed commits