Skip to content

fix(ui): stabilize backend lifecycle tests - #12828

Merged
mudler merged 1 commit into
masterfrom
ui/stabilize-release-gate-tests
Oct 22, 2026
Merged

mudler merged 1 commit into
masterfrom
ui/stabilize-release-gate-tests

Conversation

@mudler-agent

Copy link
Copy Markdown
Collaborator

Description

Stabilize two backend UI tests without changing production behavior:

  • Wait for the node-specific, enabled reinstall control before invoking its handler in both deletion-concurrency cases. The generic control shares its accessible name and can remain rendered after a URL update. Assert the exact targeted POST and retain all deletion-conflict checks.
  • Seed installed backend inventory for legacy navigation. Assert the rendered selection and complete canonical URL after inventory loads. Cover missing-selection cleanup separately, preserving URL refinements and existing final-node deletion coverage.

These address intermittent assertions in tests introduced by #12785 and #12526. No production code, configuration, timeouts, retries, or coverage gates change.

Notes for Reviewers

Verification uses Chromium, one worker, and retries disabled:

cd core/http/react-ui
npx playwright test e2e/backends-installed-node-removal.spec.js e2e/canonical-resource-navigation.spec.js --retries=0 --workers=1
npx playwright test e2e/backends-installed-node-removal.spec.js --grep 'generic deletion blocks targeted install' --repeat-each=5 --retries=0 --workers=1
npx eslint e2e/backends-installed-node-removal.spec.js e2e/canonical-resource-navigation.spec.js

Before the final exact-request assertion, both complete specs passed (41 tests), and five affected cases passed ten repetitions (50 tests). Independent verification also passed both complete specs. After that assertion, both concurrency variants passed ten local repetitions and six independent repetitions. Targeted lint and diff checks pass.

The original signatures reproduced with retries off. Negative controls confirm that settled navigation rejects absent inventory and cleanup distinguishes present from missing selections. No full-suite or coverage-gate result is claimed.

Signed commits

  • Yes, I signed my commits (maintainer DCO sign-off).
  • Documentation updated (docs/content/) for user-facing changes, or not applicable — test-only changes.

Wait for the node-specific reinstall control after URL navigation.
The generic control shares its name and can retain the previous handler.

Seed installed inventory before checking legacy backend navigation.
Assert rendered selection and cover missing-selection cleanup separately.
Keep deletion conflicts and final-node cleanup assertions intact.

Assisted-by: nib:gpt-6.1-sol
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@mudler
mudler merged commit 15e37df into master Oct 22, 2026
55 of 60 checks passed
@mudler
mudler deleted the ui/stabilize-release-gate-tests branch October 22, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants