Skip to content

test(mcpconns): cover Streamable HTTP and legacy SSE connectors - #12848

Closed
rossigee wants to merge 2 commits into
mudler:masterfrom
rossigee:fix/agent-mcp-streamable-http
Closed

rossigee wants to merge 2 commits into
mudler:masterfrom
rossigee:fix/agent-mcp-streamable-http

Conversation

@rossigee

@rossigee rossigee commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

Refs #12847.

Adds regression specs for MCP connectors in core/services/studio/mcpconns, the path that agent runs use to reach their MCP servers. Connecting must work over both transports:

  • A Streamable HTTP server connects promptly and its tools are listed.
  • A legacy SSE server still connects and its tools are listed.

The earlier code change for this issue is no longer needed: agent MCP connections already go through mcpconns.openConn, which calls mcptransport.Connect with ConnectTimeout. This PR is therefore test-only.

Notes for Reviewers

  • Diff is one new file: core/services/studio/mcpconns/transport_test.go.
  • The specs go through Service.Resolve, the same entry point agent runs use.

Validation:

  • go vet and gofmt are clean for core/services/studio/mcpconns.
  • The full mcpconns suite passes (42 of 42), including both new specs.

Signed commits

  • Yes, I signed my commits.
  • No user-facing docs change required.

@rossigee
rossigee force-pushed the fix/agent-mcp-streamable-http branch from aaf27ce to 76a3abe Compare October 23, 2026 00:09
@localai-org-maint-bot

Copy link
Copy Markdown
Collaborator

@mudler source review complete against master f1ff707b9: the agent path now uses the existing transport helper correctly, with Streamable HTTP first, bounded SSE fallback, and the agent context preserved. No blocking code findings.

I pushed the small missing docs update as 86a6f0b33: the agent section now explains transport selection and the shared discovery timeout.

Validation: the PR integrates cleanly with current master; go test ./pkg/mcptransport -count=1 -timeout=60s passes; formatting and diff whitespace checks pass. The focused agent tests could not run because downloading LocalAGI from proxy.golang.org returned Forbidden. These new regression specs still need CI validation; I am not claiming the full agent suite passes.

Source-review sign-off, conditional on CI and human DCO certification of the docs commit. The commit includes Assisted-by; repository policy reserves Signed-off-by for the human contributor.

@rossigee
rossigee force-pushed the fix/agent-mcp-streamable-http branch 3 times, most recently from aa7dad6 to f134ed7 Compare November 2, 2026 08:25
Connecting a connector must reach both MCP transports. Adds specs that resolve a
Streamable HTTP server promptly and a legacy SSE server, through the same
mcptransport.Connect path that agent runs use.

Signed-off-by: rossg <ross@golder.org>
@rossigee
rossigee force-pushed the fix/agent-mcp-streamable-http branch from 1625085 to 3a91796 Compare November 2, 2026 09:44
@rossigee rossigee changed the title fix(agents): connect agent MCP servers over Streamable HTTP test(mcpconns): cover Streamable HTTP and legacy SSE connectors Nov 3, 2026
@mudler-agent

Copy link
Copy Markdown
Collaborator

Landed on master in 71e9856. Author kept. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants