Repository navigation
Conversation
aaf27ce to
76a3abe
Compare
|
@mudler source review complete against master I pushed the small missing docs update as Validation: the PR integrates cleanly with current master; Source-review sign-off, conditional on CI and human DCO certification of the docs commit. The commit includes |
aa7dad6 to
f134ed7
Compare
Connecting a connector must reach both MCP transports. Adds specs that resolve a Streamable HTTP server promptly and a legacy SSE server, through the same mcptransport.Connect path that agent runs use. Signed-off-by: rossg <ross@golder.org>
1625085 to
3a91796
Compare
|
Landed on master in 71e9856. Author kept. Thanks! |
Description
Refs #12847.
Adds regression specs for MCP connectors in
core/services/studio/mcpconns, the path that agent runs use to reach their MCP servers. Connecting must work over both transports:The earlier code change for this issue is no longer needed: agent MCP connections already go through
mcpconns.openConn, which callsmcptransport.ConnectwithConnectTimeout. This PR is therefore test-only.Notes for Reviewers
core/services/studio/mcpconns/transport_test.go.Service.Resolve, the same entry point agent runs use.Validation:
go vetandgofmtare clean forcore/services/studio/mcpconns.mcpconnssuite passes (42 of 42), including both new specs.Signed commits