Update README.md#6
Open
bastiaan13345 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the README’s Docker usage example for running SkillServer with environment variables.
Changes:
- Changed the Docker port mapping from
8080to8034in the env-var-based example. - Updated
SKILLSERVER_PORTin that example to8034.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+102
to
+104
| docker run -p 8034:8034 \ | ||
| -e SKILLSERVER_DIR=/app/skills \ | ||
| -e SKILLSERVER_PORT=8080 \ | ||
| -e SKILLSERVER_PORT=8034 \ |
There was a problem hiding this comment.
The Docker example switches the exposed and configured port to 8034, but the rest of the README (and the application default in cmd/skillserver/main.go) still uses 8080. This creates conflicting instructions (e.g., default port table, other Docker example, and the localhost URL). Either keep this example on 8080, or update all related README references (and any code defaults if intended) so the documented port is consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.