[popups] Fix programmatic focus return#4849
Open
atomiks wants to merge 1 commit into
Open
Conversation
atomiks
added
component: alert dialog
commit: |
Bundle size
PerformanceTotal duration: 1,203.16 ms -120.51 ms(-9.1%) | Renders: 50 (+0) | Paint: 1,842.00 ms -170.38 ms(-8.5%)
9 tests within noise — details Check out the code infra dashboard for more information about this PR. |
atomiks
force-pushed
the
codex/fix-programmatic-focus-return
branch
from
3e76c18 to
47f079d
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
codex/fix-programmatic-focus-return
branch
from
47f079d to
55a20ef
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
codex/fix-programmatic-focus-return
branch
from
55a20ef to
9c7e953
Compare
atomiks
force-pushed
the
codex/fix-programmatic-focus-return
branch
from
9c7e953 to
f6a8e63
Compare
atomiks
requested review from
colmtuite,
flaviendelangle and
michaldudak
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4169
Controlled dialogs and popovers can be associated with a triggerId even when a separate control opened them programmatically. This returns focus to that originating control on close instead of always preferring the associated trigger.
Root cause
The default return-focus path preferred the associated reference trigger, even for programmatic opens where the focused opener was a different control.
Changes