[menu] Fix submenu trigger interactions#4892
Open
atomiks wants to merge 1 commit into
Open
Conversation
atomiks
added
component: menu
commit: |
Bundle size
PerformanceTotal duration: 1,451.98 ms +202.97 ms(+16.3%) | Renders: 50 (+0) | Paint: 2,208.58 ms +313.19 ms(+16.5%)
…and 1 more (+6 within noise) — details Check out the code infra dashboard for more information about this PR. |
atomiks
force-pushed
the
codex/menu-runtime-bugs
branch
from
5a7e3b2 to
e4b0b8e
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
requested review from
colmtuite,
flaviendelangle and
michaldudak
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the Codex component behavior and test coverage sweep. It fixes Menu behavior bugs found during review and adds focused test coverage for the affected paths.
Changes
Menu.SubmenuTriggerlabels for typeahead.highlightItemOnHover={false}for submenu triggers.Menu.SubmenuTriggerconformance against the actual submenu trigger element.Original findings addressed
Menu.SubmenuTriggerignores itslabelprop for typeahead.highlightItemOnHover={false}is bypassed for submenu triggers.Menu.SubmenuTriggerconformance is effectively untested.