Replace json/ujson with msgspec - #98
Open
rschlaikjer wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
Autotester: https://tiny.mujin.co.jp/g2tl7 |
Member
|
Could you update the PR description to explain this change? |
rschlaikjer
force-pushed
the
rs-migrate-msgspec
branch
from
August 6, 2026 04:38
b394f5e to
849ee7c
Compare
Rename EncodeJson/DecodeJson to EncodeJSON/DecodeJSON and have DecodeJSON raise APIServerError instead of ValueError, matching the rest of the response-parsing paths. Also restore alphabetical order in pyproject deps.
woswos
self-requested a review
August 7, 2026 04:06
… message DecodeJSON now decodes bytes before formatting them into the APIServerError message, truncates the body at 1000 characters and logs like the other decode sites. CallAPI uses it instead of duplicating the try/except. Also drop the stale python 2 comment on _MergeDicts.
…wrappers Make the wrappers the single choke point for JSON handling instead of letting internal call sites reach for the msgspec codecs directly, and document the non-ASCII wire encoding change in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace json/ujson usage with msgspec for performance.
In the event that types are not serializable with msgspec, the custom encoder hook will fall back to using ujson for those specific types.