add entries for BIP-340: public/private key and varsig#398
Merged
vmx merged 1 commit intomultiformats:masterfrom Apr 16, 2026
Merged
add entries for BIP-340: public/private key and varsig#398vmx merged 1 commit intomultiformats:masterfrom
vmx merged 1 commit intomultiformats:masterfrom
Conversation
While bip340 operates on secp256k1, it makes sense to have separate values: - public keys have a different format: 32-byte x-only (bip340) vs 33-byte prefix+x (secp256k1) - private keys have the same format but different usage expectation - algorithm are different: schnorr (bip340) vs ECDSA (secp256k1) - signatures have a different format: 64-byte [R.x, s] (bip340) vs 64-byte [r, s] (secp256k1) That is, they can't reasonable mix or interoperate.
MichaelMure
requested review from
aschmahmann,
darobin,
rvagg and
vmx
as code owners
dovydas55
approved these changes
Mar 24, 2026
vmx
approved these changes
Mar 30, 2026
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
I haven't had a close look. But it looks reasonable. If no one else finds the time for a review, I think it's good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While bip340 operates on secp256k1, it makes sense to have separate values:
That is, they can't reasonable mix or interoperate.
I tried to pick values that makes sense, let me know if I should change them.