Fix branch snapshot isolation#32
Merged
Merged
Conversation
Signed-off-by: Cong Wang <cwang@multikernel.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inherited/directory, instead of walking the live ancestor chain on every lookup.resolve_pathandcollect_dir_namesnow consult only the branch's own delta plus its frozen inherited snapshot; the live base is only used bymain. This makes a branch's view immune to subsequent writes on its parent._lockedhelpers so the snapshot can be built atomically while holding the branches lock; failure during snapshotting cleans up the partially-created branch directory.Test plan
cargo testtests/test_branch_dirs.shtests/test_commit.sh🤖 Generated with Claude Code