core: add Sandbox::spawn() that awaits execve completion#52
Merged
Conversation
Signed-off-by: Cong Wang <cwang@multikernel.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sandbox::spawn()andSandbox::spawn_interactive()— sugar forcreate() + start()that additionally blocks until the child has actually finishedexecve()and is executing user code. Mirrors Python'sSandbox.spawn()but with stronger semantics, since the Rust supervisor's checkpoint/state-reading operations depend on the child being pastexecve./proc/<pid>/exeno longer matching/proc/self/exe(beforeexecvethe child still shares the supervisor's binary). Polled every 1ms with a 5s ceiling; condition is real, the interval is just granularity.test_checkpointcases to usespawn_interactive, removing the hand-rolledtokio::time::sleep(100ms)"give it a moment to start" waits that were flaky under CI load. Test suite now finishes in ~10ms instead of ~500ms minimum.Test plan
cargo test -p sandlock-core --test integration test_checkpoint(7 passed in 0.01s)cargo test --workspace(all suites green)