Fix animation query crash for streamed-out peds#5057
Open
HeresHavi wants to merge 1 commit into
Open
Conversation
Prevent animation progress, speed, and length queries from accessing missing task data on streamed-out peds. These queries now return -1 when the task manager or active task is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added missing task checks to
getPedAnimationProgress,getPedAnimationSpeed, andgetPedAnimationLength.These functions now return
-1when the ped has no task manager or active task.Motivation
A streamed-out ped can still be a valid Lua element, but it no longer has native task data. Querying its animation progress tried to access that missing data and caused an access violation. The speed and length functions had the same unchecked path.
For example, a server resource might track an NPC's animation to update a progress bar or other UI. If the player moves far enough away and the NPC streams out, the resource can still hold the ped element. The next animation query could crash the player's client.
Crash Stack
Test plan
Runtime
-1for the same ped, and the client stayed open.Builds and Tests
Debug | Win32: Build passed, 304 client tests passed.Release | Win32: Build passed, 304 client tests passed.Debug | x64: Server build passed.clang-format.Checklist