Fix setPedAnimation not initializing animation cache on success#5083
Open
QueryOfficial wants to merge 1 commit into
Open
Fix setPedAnimation not initializing animation cache on success#5083QueryOfficial wants to merge 1 commit into
QueryOfficial wants to merge 1 commit into
Conversation
This update initializes the animation cache parameters (startTime, speed, and progress) for the Ped entity within the SetPedAnimation method, ensuring proper handling of animation states during gameplay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On successful local
setPedAnimationpaths, earlyreturn trueskipped the trailingm_AnimationCache.startTime = GetTimestamp()assignment. InitializestartTime,speed, andprogressbefore those returns (normal + IFP gateway paths), and remove the unreachable assignment after the branch.Motivation
Client-local
setPedAnimationnever primed the animation cache on success (unlike RPC-driven setup). That breaks stream-in progress restore and time-based checks that depend onstartTime. Split out from thegetPedAnimationpartial-anim PR so each change stays focused.Test plan
setPedAnimation(ped, block, anim, ...)on a streamed-in ped, then stream the ped out and back in — timing/progress should resume from a sensible start, not look unset/stuck.setPedAnimationpath — same cache init, no regression.setPedAnimation(ped, false)/ clear animation still works.Checklist