🐛 Use valid OpenQASM in DDSIM status test - #2345
Closed
simon1hofmann wants to merge 1 commit into
Closed
Conversation
Use a scalar bit condition and avoid a redundant register remeasurement that is ill-typed after indexed access. Assisted-by: GPT-5.6 via Codex
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
burgholzer
reviewed
Sep 3, 2026
| // Measure all qubits | ||
| c = measure q; | ||
| // Add dynamic component | ||
| if (c == 3) { |
Member
There was a problem hiding this comment.
This is valid OpenQASM 3, is it not?
Contributor
Author
There was a problem hiding this comment.
Yes you're right and this should be fixed by #2181. Closing this workaround for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Use valid OpenQASM 3 in the DDSIM device-status test fixture:
c[0]instead of comparing a bit register with an integer;Validation
BUSY, completed with the requested shot count, and returned toIDLEgit diff --checkChecklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).