Make dock toggle raise an open panel that is hidden behind another tab

[Ash-86]

Pressing a panel's shortcut (e.g. P for the piano keyboard) while it was
open but hidden behind another tab closed it, so the user had to press
the shortcut twice to see it.

DockPageView::toggleDock now brings an open, non-current panel tab to
the front, and only closes a panel that is already the current tab.

This was the behaviour in MU3.

Resolves: musescore/MuseScore#35122

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b5609d6f-eb52-445d-99a4-501aaf0a1014

📥 Commits

Reviewing files that changed from the base of the PR and between 404fb5c and 300c996.

📒 Files selected for processing (3)

• framework/dockwindow/qml/Muse/Dock/dockpageview.cpp
• framework/dockwindow/qml/Muse/Dock/dockpanelview.cpp
• framework/dockwindow/qml/Muse/Dock/dockpanelview.h

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

DockPageView now ignores unknown dock names. If a dock is an open DockPanelView that is not the current tab, toggling selects it without closing it. Otherwise, toggling sets the dock’s open state to the inverse of its current state. DockPanelView adds methods to query whether its tab is current and to make it current.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 300c9

The toggle change matches the described behavior, and the identified lifecycle concern is ruled out. No merge-blocking issue remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The description explains the problem, the behavior change, and the resolved issue. However, it leaves every required checklist item unchecked, despite the template stating that the checklist must be c…	Complete each checklist item accurately. Mark applicable items as complete, and explain any item that does not apply. If AI assistance was used, complete the AI-assistance item and list the tools used.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the main change: toggling an open panel brings it to the front when another tab is current.

Full details: Description check

Explanation

The description explains the problem, the behavior change, and the resolved issue. However, it leaves every required checklist item unchecked, despite the template stating that the checklist must be completed accurately.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}