Repository navigation
fix(devcontainer): converge mise to its pin, drop the deprecated Copilot extension, and name volumes per DEVC-08 - #162
Merged
Conversation
…lot extension, and name volumes per DEVC-08
base_install_mise skipped whenever any mise was on PATH, so a container created before min_version moved kept an older mise that refused the config and installed none of the pinned CLIs. It now replaces any mise that is not the pinned release.
github.copilot is deprecated since VS Code 1.109; github.copilot-chat provides the whole experience.
The named volumes become musher-${devcontainerId}-<purpose>, the form EC-0027 DEVC-08 checks from engineering-conventions 0.6.3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Justin Merrell <merrelljustin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the dev container review done alongside #160. Tracks with musher-dev/engineering-conventions#65.
What changes
base_install_miseused to skip whenever anymisewas on PATH. A container created beforemin_versionmoved to2026.9.12kept2026.9.6, which refuses the config, so none of the pinned CLIs installed, andtask check:conventionsfailed withmise version 2026.9.12 is required. It now replaces any mise that is not the pinned release. Both branches were tested: the matching version skips, and a stubbed2026.9.6is replaced.github.copilotis deprecated since VS Code 1.109, andgithub.copilot-chatprovides the whole experience.musher-spec-${devcontainerId}-<purpose>becomesmusher-${devcontainerId}-<purpose>, the form engineering-conventions EC-0027 DEVC-08 checks from 0.6.3 on. This repository pins 0.6.1 today, so nothing reports it yet, and the upgrade will not add a finding.Before you rebuild: keep your volumes' data
A renamed volume starts empty. That means a new
gh auth login, and a fresh~/.claudeand~/.codex, including agent memory and history. To carry the data over, stop the container, then run this on the host in a POSIX shell (WSL on Windows) before rebuilding.${devcontainerId}does not change, so each old volume maps to its new name:Once the rebuilt container shows your data, remove the old volumes with
docker volume rm <name>.Checks
task check:shell,check:formatandcheck:conventionspass. The Validate dev container workflow builds the container with--frozen-lockfile.🤖 Generated with Claude Code