Repository navigation
docs(core): name ERR_INVALID_NUMBER and fix two stale citations - #170
Merged
Merged
Conversation
§6.1 now names the code an unsafe number is rejected with, as §7 and parser/016 already do. §9 points at ADR 0037 §3, which moved the edition record to specification.json, and §11's self-contained-bundle claim cites Using the schemas, which states it, instead of the README, which does not. Refs #166 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Justin Merrell <merrelljustin@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #166.
What changes
Three prose corrections in core v1. None changes what validates.
ERR_INVALID_NUMBERfor non-finite numbers and unsafe integers. §7's table andparser-016-reject-unsafe-integeralready give that code. §6.1 was the only rejection in that section that named no code.release.jsontospecification.json, and citing only ADR 0023 sent readers to the old file name.Why
#166 needs a core release cut through the post-ADR 0037
release.yml, so that core's release carriesSHA256SUMS. The workflow already writes and attestsSHA256SUMSfor core (#164), and Publication → Release assets already lists it. core 1.1.0 predates #164, and nothing has changed in core since. Thisdocscommit is a genuine correction that also triggers core 1.1.1.Merge order: this first, then its release PR, then the component PR, then the blueprint PR. A pending family entry fails while core carries an unreleased releasable commit.
Compatibility
Checks
task checkpasses on the blueprint branch built from the samemain. On this branch it passed everything except onereplayConcurrentlytest, which hit its 5 s timeout under local load and passed in the other run. CI is the authority.🤖 Generated with Claude Code