feat: support service banner for TCP#168
Conversation
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
glaslos
left a comment
There was a problem hiding this comment.
Please add a README.md into the responses folder with a not where the responses are sourced from.
|
Just to confirm:
|
|
1 and 2 is correct. For 3, just read once, no need to read until max payload, that is just protection. |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
|
what tool should I use to hit the target? |
|
try netcat: |
|
I tried to test it and the banner isn't sent as soon as connected, but until attacker's payload. Is this how it should work? |
|
You need to send the banner before we peek the connection here |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
|
Tested locally with TCP port 4444. works good. |
|
Have a look at the failing test. |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
|
Tests are failing.... |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
|
Test is getting timeout error. |
|
I pushed a change to the main branch introducing the timeout on the buffered connection we use for peeking. |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
fixes #53
TCP handler can handle other target ports without need of seperate port handlers.