perf(decoder): add bounded columnar decoding - #4
Merged
Conversation
muthmann
marked this pull request as ready for review
August 12, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User impact
Existing
decode_file,decode_file_with_triggers, anddecode_bytescalls remain compatible and use the optimized core automatically. Large-file users can opt intodecode_file_batches; users who need external trigger edges can usedecode_file_batches_with_triggers, which yields(Events, TriggerEvents)per bounded batch.Measured on
test_data/laser.raw:The Rust and C++ CSV outputs were byte-identical on an 8-MiB input prefix. The benchmark runner now verifies this and alternates measured run order.
Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace398d63a52eeb7291caa1346037f674ef0b6209772d3c512e2aa6c70b9aed12f4Real ECF fixture checks were skipped because the external ECF plugin is not installed. Synthetic HDF5 and HDF5 batch tests passed.