fix: Make translation check stricter and deterministic#33
Merged
Conversation
- Add version header validation to _check_pot_freshness - Add entry flags validation (python-format, no-python-format, etc.) - Extract helper functions for version, msgid, and flag checking - Update POT and PO files to use correct version (2.0.0a0) - Update tests to use proper POT header template with version The check command now validates: - msgid completeness (existing) - Header version matches package version (new) - Entry flags match freshly extracted POT (new) This ensures the translation workflow produces consistent results and catches version mismatches introduced by PR #32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_pot_freshnessProblem
After PR #32 centralized the version in pyproject.toml, running
manage-translations extractproduced changes because:2.0.0butbirdnetpi.__version__now returns2.0.0a0The existing check only validated msgid completeness, not header version or entry flags.
Solution
The check command now validates:
birdnetpi.__version__(new)Test plan
manage-translations checkpasses after running workflow