Fix propagation of headers with grpc server errors#42
Open
technicianted wants to merge 4 commits intomwitkow:masterfrom
Open
Fix propagation of headers with grpc server errors#42technicianted wants to merge 4 commits intomwitkow:masterfrom
technicianted wants to merge 4 commits intomwitkow:masterfrom
Conversation
|
God, I did the same thing |
Author
|
@e421083458 feel free to use my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation does not propagate headers if grpc error is returned.
This PR fixes ordering of header forwarding in handler.go such that it carries headers even if there was an error.
Relevant unit tests added for unary and streaming calls.