Fix KeyError when metadata.container is missing in People parser#593
Open
SS-4 wants to merge 1 commit intomxrch:masterfrom
Open
Fix KeyError when metadata.container is missing in People parser#593SS-4 wants to merge 1 commit intomxrch:masterfrom
SS-4 wants to merge 1 commit intomxrch:masterfrom
Conversation
…tainer is missing in People parser Fixes crash caused by missing "metadata.container" in Google responses. Replaced unsafe dictionary access with safe .get() checks across people.py. Prevents KeyError and allows parsing to continue when fields are missing.
Author
|
Note: I replaced multiple unsafe accesses in one pass because the same issue occurs in several places (emails, names, photos, etc.). Happy to reduce this to minimal changes if preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GHunt crashes with:
KeyError: 'container'
This happens because Google responses sometimes omit "metadata.container".
Fix
Replaced unsafe dictionary access:
data["metadata"]["container"]
with safe access:
data.get("metadata", {}).get("container")
Result
Tested locally — resolves crash across multiple emails.