Skip to content

chore: bump playground Playwright to 1.62.x, keep @playwright/test at 1.60 - #318

Open
mxschmitt wants to merge 5 commits into
mainfrom
cursor/upgrade-playwright-4443
Open

chore: bump playground Playwright to 1.62.x, keep @playwright/test at 1.60#318
mxschmitt wants to merge 5 commits into
mainfrom
cursor/upgrade-playwright-4443

Conversation

@mxschmitt

@mxschmitt mxschmitt commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Rebased onto origin/main.

Playground runtimes and editor types move to Playwright 1.62.x. @playwright/test stays on 1.60.0 (e2e + frontend component tests) so CI keeps Firefox 150 and does not hit the Firefox 153 worker-reload SIGSEGV (microsoft/playwright#42565).

  • JavaScript worker / README badge: 1.62.1
  • Python, Java, and .NET workers: 1.62.0
  • Editor types.txt from current playwright-core
  • Other frontend/e2e npm deps from npm-check-updates (TypeScript 7, vite 8, rsuite, etc.)
  • monaco-editor stays 0.55.1
  • No Firefox-specific Monaco worker skip (not needed for e2e on 1.60). Site visitors on Firefox 153+ can still crash on share/reload until a Playwright Firefox roll includes Bugzilla 2044428.

Local checks: npm run build and npx playwright test in frontend/ (63 passed).

Live logs: #320

Open in Web Open in Cursor 

@mxschmitt
mxschmitt marked this pull request as ready for review September 3, 2026 19:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T19:18:29.431713Z 07a6df0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

cursoragent and others added 4 commits September 4, 2026 21:55
Bump Playwright workers, editor types, and npm packages via update_pw.mjs.

Co-authored-by: Max Schmitt <max@schmitt.mx>
…itor 0.56

TypeScript 7 removes node10 module resolution and esModuleInterop=false.
Monaco 0.56 remaps package exports, so worker and API imports need the new paths.

Co-authored-by: Max Schmitt <max@schmitt.mx>
Playwright 1.62 ships Firefox 153, which crashes the tab when Monaco
creates its TypeScript language worker a second time after navigation.
Skip that worker (and extra libs) on Firefox, dispose the editor on
unload, and keep monaco-editor on 0.55.1.

Co-authored-by: Max Schmitt <max@schmitt.mx>
E2E and frontend component tests stay on Playwright 1.60 (Firefox 150) to
avoid the Firefox 153 worker-reload SIGSEGV. Worker images, editor types,
and the README badge remain on 1.62.x.

Co-authored-by: Max Schmitt <max@schmitt.mx>
@cursor
cursor Bot force-pushed the cursor/upgrade-playwright-4443 branch from 2f58c4f to 6a49dff Compare September 4, 2026 21:58
@cursor cursor Bot changed the title chore: update Playwright to 1.62.1 and dependencies chore: bump playground Playwright to 1.62.x, keep @playwright/test at 1.60 Sep 4, 2026
E2E stays on @playwright/test 1.60 (Firefox 150), so the share-reload
SIGSEGV does not apply to CI. Production Firefox 153+ can still hit
microsoft/playwright#42565 on reload while the worker compiles.

Co-authored-by: Max Schmitt <max@schmitt.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants