chore: bump playground Playwright to 1.62.x, keep @playwright/test at 1.60 - #318
Open
mxschmitt wants to merge 5 commits into
Open
chore: bump playground Playwright to 1.62.x, keep @playwright/test at 1.60#318mxschmitt wants to merge 5 commits into
mxschmitt wants to merge 5 commits into
Conversation
mxschmitt
marked this pull request as ready for review
September 3, 2026 19:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bump Playwright workers, editor types, and npm packages via update_pw.mjs. Co-authored-by: Max Schmitt <max@schmitt.mx>
…itor 0.56 TypeScript 7 removes node10 module resolution and esModuleInterop=false. Monaco 0.56 remaps package exports, so worker and API imports need the new paths. Co-authored-by: Max Schmitt <max@schmitt.mx>
Playwright 1.62 ships Firefox 153, which crashes the tab when Monaco creates its TypeScript language worker a second time after navigation. Skip that worker (and extra libs) on Firefox, dispose the editor on unload, and keep monaco-editor on 0.55.1. Co-authored-by: Max Schmitt <max@schmitt.mx>
E2E and frontend component tests stay on Playwright 1.60 (Firefox 150) to avoid the Firefox 153 worker-reload SIGSEGV. Worker images, editor types, and the README badge remain on 1.62.x. Co-authored-by: Max Schmitt <max@schmitt.mx>
cursor
Bot
force-pushed
the
cursor/upgrade-playwright-4443
branch
from
September 4, 2026 21:58
2f58c4f to
6a49dff
Compare
E2E stays on @playwright/test 1.60 (Firefox 150), so the share-reload SIGSEGV does not apply to CI. Production Firefox 153+ can still hit microsoft/playwright#42565 on reload while the worker compiles. Co-authored-by: Max Schmitt <max@schmitt.mx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto
origin/main.Playground runtimes and editor types move to Playwright 1.62.x.
@playwright/teststays on 1.60.0 (e2e + frontend component tests) so CI keeps Firefox 150 and does not hit the Firefox 153 worker-reload SIGSEGV (microsoft/playwright#42565).types.txtfrom currentplaywright-corenpm-check-updates(TypeScript 7, vite 8, rsuite, etc.)monaco-editorstays 0.55.1Local checks:
npm run buildandnpx playwright testinfrontend/(63 passed).Live logs: #320