Deploy file-service on autoupdate so /file-uploads works in prod - #335
Merged
Conversation
#334 moved /file-uploads GET from RustFS to file-service, but upgrade_k3s_containers.sh pulled frontend:latest and explicitly skipped file. Production Caddy now proxies screenshots to file:8080 while the file pod still has no download handler, so every image 404s. Pull file-service:latest, restart deployment/file, and re-exec the repo script after reset so this list is used on the same deploy cycle. Co-authored-by: Max Schmitt <max@schmitt.mx>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why production is still broken
#334 is merged and CI built
file-service:latest/frontend:latest. Autoupdate then pulled frontend and restarted it (new Caddyfile proxies/file-uploads/*tofile:8080) but explicitly skipped file:Live check:
GET https://try.playwright.tech/file-uploads/foo.pngreturns Echo JSON{"message":"Not Found"}(Caddy → old file-service with no download route). A new handler would 400 invalid names.Until
deployment/fileruns the #334 image, every screenshot 404s.This PR
file-service:latestand restartdeployment/filegit reset --hard, re-exec the script so the new image list applies on the same cycleHost (do this now, do not wait for cron)
Then re-run a snippet on https://try.playwright.tech/ (new UUID; Cloudflare may have cached old 404s).