fix(proto): Gracefully handle invalid PATH_ACK frames#592
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/592/docs/noq/ Last updated: 2026-04-14T15:05:56Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5937.2 Mbps | 8063.2 Mbps | -26.4% | 96.4% / 149.0% |
| medium-concurrent | 5449.9 Mbps | 7384.3 Mbps | -26.2% | 95.5% / 100.0% |
| medium-single | 4341.1 Mbps | 4732.5 Mbps | -8.3% | 99.6% / 150.0% |
| small-concurrent | 3974.5 Mbps | 5309.8 Mbps | -25.1% | 93.8% / 103.0% |
| small-single | 3629.5 Mbps | 4713.6 Mbps | -23.0% | 95.4% / 104.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | N/A | 3967.3 Mbps | N/A |
| lan | N/A | 810.4 Mbps | N/A |
| lossy | N/A | 69.9 Mbps | N/A |
| wan | N/A | 83.8 Mbps | N/A |
Summary
noq is 22.8% slower on average
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes some bugs found via #585.
When a connection doesn't support multipath, or it receives a malicious or misconstructed PATH_ACK frame that has e.g. a
path_idof1, which the current connection may not actually have any state for, this would previously cause us to panic.With this change we exit out with a PROTOCOL_VIOLATION connection close instead.
Notes & open questions
I don't have a regression test for this yet. It is generated in #585 and uses the test setup from #589, which both aren't merged yet.
I'll make sure to re-generate the regression test and add it in #585 once that's ready.
Change checklist