Improve error logging #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identify what type of communication to have with the device is not user-friendly. This PR look to improve it. Signed-off-by: Pascal Hernandez <pascal.hernandez@nordicsemi.no>
gregersrygg
reviewed
Jan 9, 2026
gregersrygg
left a comment
gregersrygg
left a comment
There was a problem hiding this comment.
Thanks for improving the error handling 👍 It's nice to catch errors, but this doesn't make the error messages more understandable for the users as far as I can tell. It just prints the error message without the full stacktrace. It's also only catching TimeoutErrors. Is that the only type of error? Wouldn't there be a different error if the user has another terminal connected to the device? I run into that problem very often.
Also, I recommend doing this within detect_shell_mode or to make a util function so this logic only needs to be maintained one place.
Contributor
Author
|
@gregersrygg I will handle the error inside the function that detect the shell mode. I'm closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception displayed in case there is a timeout when trying to identify what type of communication to have with the device is not user-friendly. This PR look to improve it.