refactor: テストデータパーサーをTemplate Methodパターンで整理 - #75
Draft
kiyotis wants to merge 14 commits into
Draft
Conversation
kiyotis
changed the title
kiyotis
force-pushed
the
convert-testdata-excel-to-text
branch
2 times, most recently
from
June 16, 2026 06:47
7efc1ed to
2818ffb
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kiyotis
force-pushed
the
convert-testdata-excel-to-text
branch
from
June 23, 2026 08:26
d5bd33f to
d799c0a
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
設計書・NTF解説書・仕様リストの不整合を実装コードを正として修正。 設計書 (testdata-converter-design.md): - TestDataFormatReader#read シグネチャを read(basePath, resourceName) に修正 - ConverterMojo を FormatHandler/ConversionRequest 等の実際の構成に差し替え - TestCoreReaderAdapter の追加メソッド (readSendSyncMessages/readHeaders/readBlockBodyLines) を追記 - YamlTestCoreAdapter に isResourceExisting を追記 - TestDataBlock のフィールド (dataType/groupId/identifier) をクラス図に追記 - FileDataBlock の FileType enum をクラス図に追記 - YamlTestDataValidator/ValidationError を OUT 節に追記 - 重複していた「依存の向き」ブロックを削除 NTF解説書 examples: - ntf-testdata-doc-examples-messaging.md: directives: を records: 内から エントリ直下（records: と同階層）へ移動、record_type を DEFAULT → default に統一 - ntf-testdata-doc-examples-file.md 6.2節: type を英字記号 (X/N/Z) から 日本語型名称 (半角/全角/数値) に修正 仕様リスト (ntf-impl-spec-list.md): - テストメソッド名の test プレフィックスを全件除去（実装は test プレフィックスなし） - RS-20 テストメソッド名: noFwHeader → noFwHeaderFragment に修正 - RS-12/RS-20 実装マッピング: extractFwHeader → convertFwHeader に修正 - SS-22: 未実装テストを — に修正 - SS-05: テストクラスを YamlTableDataBuilderTest → YamlTestDataParserTest に修正 - MS-01/MS-04: テストメソッドのプレースホルダーを実際のメソッド名に修正 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
送信同期メッセージ（要求/応答電文 4 種）の判定ロジックを DataType enum の インスタンスメソッドとして集約した。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 6c415f6.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kiyotis
changed the title
This was referenced Jun 25, 2026
nablarch-testing-yaml 側でテストメソッド名の仕様ID依存を除去したため、 仕様一覧の参照をリネーム後のメソッド名（10件）に合わせる。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
NTFのテストデータ読み込み機構をリファクタリングし、パーサー間の重複を解消した。
変更内容
ソースコード
Template Methodパターンの導入 (
TestDataParsingTemplate)ListMapParserとTableDataParserに重複していたキャッシュ処理を抽象基底クラスに集約DataFileParser の整理
各パーサーの責務を明確化し、テストデータ解析フローを統一
ドキュメント（
docs/pr75/docs/）testdata-converter-design.md— 変換ツール設計書ntf-testdata-loading.md— テストデータ読み込み機構の解説ntf-testdata-doc.md/ntf-testdata-doc-examples-*.md— NTFテストデータ解説書テスト結果
mvn clean test（Java 17 + Maven 3.9.9）: 840件 Failures:0 Errors:0MockHttpRequestTest/MockServletExecutionContextTest）は PR75 非起因