fix(resolver): JSON-serialize array params in Mustache body templates…#214
Merged
fix(resolver): JSON-serialize array params in Mustache body templates…#214
Conversation
…, disable HTML escaping (#213)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #213
What does this PR do?
Resolver.resolveMustacheTemplatewas using JMustache with default settings, causing two issues:CollectionandObject[]values were substituted viatoString(), producing[CREW-001, CREW-003](no quotes) — invalid JSON when inserted into a body template."→"). Templates here produce JSON/URI output, never HTML, so this escaping corrupted the serialized JSON values.Fix: JSON-serialize collections using Jackson before substitution, and disable HTML escaping via
escapeHTML(false).Tests
ResolverTest#resolveMustacheTemplateShouldJsonSerializeArrayParameters— verifies that aListis properly serialized as a JSON array in the templateResolverTest#resolveMustacheTemplateShouldPreserveNonAsciiCharacters— verifies that non-ASCII characters (e.g.ø) are not corrupted by HTML escapingChecklist
mainAgent Context (optional)
agent_name: GitHub Copilot
llm: Claude Sonnet 4.6
tool: VS Code Copilot Chat
confidence: high
source_event: step-6 tutorial debug — create-voyage body rendered as invalid JSON
discovery_method: runtime_observation
review_focus: Resolver.java:resolveMustacheTemplate