Skip to content

Sync recipe with pyproject#386

Open
TimMonko wants to merge 3 commits into
napari:mainfrom
TimMonko:mnt/sync-recipe
Open

Sync recipe with pyproject#386
TimMonko wants to merge 3 commits into
napari:mainfrom
TimMonko:mnt/sync-recipe

Conversation

@TimMonko
Copy link
Copy Markdown
Contributor

@TimMonko TimMonko commented May 7, 2026

Description

I've noticed a bit of cruft in the recipe, so this tries to polish it up and sync with pyproject.

  1. use platformdirs instead of appdirs (I think this started in 0.7.0)
  2. split the napari[optional-base] dependencies from the bundle convenience dependencies

I switched from dask-base to dask -- mostly because I don't know if the previous issue with distributed is still an issue? happy to revert.

also pooch is imported in https://github.com/napari/napari/blob/dd6fe66bb248def5788849ac34a62489d9edb530/src/napari/utils/_examples_data.py#L4
but is not a dependency of napari, only transitive via scikit-image, so I think we should update napari/napari

Comment thread conda-recipe/recipe.yaml Outdated
Comment on lines +49 to +46
- dask-core >=2021.10.0
- dask >=2021.10.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change. We don't want to add dask-distributed to our dependencies here. See:
https://github.com/conda-forge/dask-feedstock/blob/df1a9402dff87c9a41cc3297b9cccc39bc768e98/recipe/recipe.yaml#L19-L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants