Merged
Conversation
Upstream fixes present: - libffi.gyp: correct preprocess_asm.cmd path for Windows (node-ffi-napi#293, node-ffi-napi#265) - src/ffi.cc: remove NAPI_EXPERIMENTAL define (node-ffi-napi#283) - node-gyp-build bumped to ^4.8.2, prebuildify to ^6.0.1 (node-ffi-napi#283)
Uses MSYS2's own Node.js package so os.type() returns MINGW64_NT-*, which activates the MinGW code path in libffi.gyp (GCC compiles .S files directly instead of the MSVC preprocess_asm.cmd route).
urbanogilson
added
bug
On MSYS2 MinGW nodes, libuv is not necessarily re-exported from the
node binary, so GetProcAddress("uv_fs_open") returns error 127. The
test still verifies that Library(null, {}) succeeds on MinGW; only the
MSVC-specific symbol export assumption is skipped.
|
sorry I didn't get to do it, you are doing god's work, thank you. |
Member
Author
|
Thanks, I appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build failures when installing
@napi-ffi/ffi-napifrom source under MSYS2 subsystems on Windows.Adds a dedicated MinGW (MSYS2 MINGW64) job to
ci.yml.Closes #1