Skip to content

Fix #138, Remove Dead Functions - #139

Open
arielswalker wants to merge 1 commit into
nasa:devfrom
arielswalker:fix-138-remove-dead-functions
Open

Fix #138, Remove Dead Functions#139
arielswalker wants to merge 1 commit into
nasa:devfrom
arielswalker:fix-138-remove-dead-functions

Conversation

@arielswalker

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes #138

Testing performed
Ran the native_std commands which includes prep, install, runtest, and lcov. Compared these lcov results against the unchanged cFS bundle and found no changes. Ran the old build commands with unit tests enabled to ensure that the internal static code analysis tool no longer flags these functions. Also ran the bundle with -Wunused flags which only flagged unrelated macros.

Expected behavior changes
Removes five dead functions which are

  1. CS_CMDS_TEST_CFE_ES_CreateChildTaskHook
  2. CS_COMPUTE_TEST_CFE_TBL_GetInfoHook1
  3. CS_TABLE_PROCESSING_TEST_CFE_ES_GetAppNameHandler1
  4. CS_TABLE_PROCESSING_TEST_CFE_TBL_GetAddressHook
  5. CS_TABLE_PROCESSING_TEST_CFE_TBL_LoadHook

System(s) tested on
RedHat, cFS dev

Additional context
Lcov bundle results using native_std:

Overall coverage rate:
  lines......: 99.2% (30304 of 30537 lines)
  functions..: 99.2% (2428 of 2447 functions)
  branches...: no data found

Lcov bundle results using the old build commands:

Overall coverage rate:
  lines......: 99.2% (30167 of 30396 lines)
  functions..: 99.2% (2417 of 2436 functions)
  branches...: 98.7% (12931 of 13095 branches)

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.

@arielswalker arielswalker self-assigned this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Dead Functions

1 participant