Fix #255, Releasing table address prior to issuing a table manage command - #256
Closed
DHerceg-NASA wants to merge 1 commit into
Closed
Fix #255, Releasing table address prior to issuing a table manage command#256DHerceg-NASA wants to merge 1 commit into
DHerceg-NASA wants to merge 1 commit into
Conversation
…mmand in the SAMPLE_APP_SendHkCmd() function.
dzbaker
changed the title
dzbaker
changed the title
jphickey
requested changes
Jul 22, 2026
jphickey
left a comment
jphickey
left a comment
Contributor
There was a problem hiding this comment.
This is not necessary. The sample app follows a model where it does not hold the table address.
During SAMPLE_APP_ProcessCmd(), it obtains the table address on line 123, uses the data, and releases it on line 135.
Contributor
|
Closing this PR. Please re-open if there is a situation where the table address was being held which made this necessary and we can re-evaluate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing table address prior to issuing a table manage command in the SAMPLE_APP_SendHkCmd() function.
Describe the contribution
See #255
Testing performed
Steps taken to test the contribution:
Expected behavior changes
System(s) tested on
Additional context
See #255
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request